AI4Finance-Foundation / AI4Finance-Foundation/FinRL

Open Time Bug

Abierto
#981 5 comentarios 0 reacciones 0 asignados Ver en GitHub
fixed refactoring
Lenguaje dominante
Jupyter Notebook
Estrellas
16.3k
Forks
3.5k
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

I was trying to run the notebooks (after downgrading the Pandas to 1.5.3, since the new release to 2.0.0 removed the pd.TimeDelta().delta, which was prevented from downloading the files.) And I found that all the first rows were NaN. This was messing with the data and the indicators. Then reading through the data I realized that my data is starting at 10:30 AM and the code started reading the rows at 9:30. So I hardcoded the 10:30 in my local env. I don't know if that is related to summer time that we just entered or which other cause.

**To Reproduce**
Steps to reproduce the behavior:
1. Go to ['Tutorial'](https://colab.research.google.com/github/AI4Finance-Foundation/FinRL-Tutorials/blob/master/3-Practical/FinRL_PaperTrading_Demo.ipynb#scrollTo=SxYoWCDa02TW)
2. Downgrade pandas to 1.5.3 ( !pip install pandas==1.5.3)
3. Run all the cells until Part 2 Train Agent.
4. See the error

**Expected behavior**
Should Train with proper data.

**Screenshots**
With the time set to 09:30
![image](https://user-images.githubusercontent.com/43041764/231654475-3a06e66b-fece-4146-8795-596194050442.png)

With the time set to 10:30
![image](https://user-images.githubusercontent.com/43041764/231655106-3d09c2d9-f6f3-4522-9b35-a1db3427b66f.png)

Image of the data:
![image](https://user-images.githubusercontent.com/43041764/231655429-66eed686-2f08-4614-96bd-2e706bfb7691.png)

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.