AI4Finance-Foundation / AI4Finance-Foundation/FinRL-Meta

FinRL_MultiCrypto_Trading example not working due to import error on from agents.elegantrl_models import DRLAgent as DRLAgent_erl

Open
#291 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
1.9k
Forks
751
PR merge metrics
No merged PRs in 30d

Description

Hi,
i am completely new to the world of FinRL and basically just started playing around.

I just tried to run the FinRL-Tutorial Notebook of FinRL_MultiCrypto_Trading. There i run into an import error caused by
`from agents.elegantrl_models import DRLAgent as DRLAgent_erl`

In `FinRL-Meta/agents/elegantrl_models.py` i saw that you try to import `from elegantrl.train.config import Arguments`

`Arguments` was sadly removed from ElegantRL in the commit: [003572d9](https://github.com/AI4Finance-Foundation/ElegantRL/commit/003572d9a37a1a302edb8bebd4fbd9c17d5ddccd#diff-1cfd748ee21b12096924794a06fa48e37e1829b9c55fde0ebd9f7e23bb782f7f)

Some Pics:
![image](https://user-images.githubusercontent.com/43827828/236348752-a639538d-f8b5-4d06-a0e7-7e3f2082babe.png)
![image](https://user-images.githubusercontent.com/43827828/236348840-b4b0d409-94a9-41af-9c5c-50eb2a33cde1.png)

Then i tried to resolve this by using commit 03db5bdda409d0b4ce2705340dd5e9be3fd090ee of ElegantRL (before the change).
Just to run into a similar issue with rllib... (I just removed that one from the example though. )
![image](https://user-images.githubusercontent.com/43827828/236350134-516f35f3-e772-4918-b2d3-7c7428c5191f.png)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.