ADORSYS-GIS / ADORSYS-GIS/lightbridge-governance

[Ticket]: de-duplicate checkpoint()/field() across eight copilot_push tests

Abierto
#237 1 comentario 0 reacciones 0 asignados Ver en GitHub
ticket
Lenguaje dominante
Rust
Estrellas
1
Forks
2
Merge medio
13 h 13 min
PR fusionados (30 d)
110

Descripción

## Summary

Seven `copilot_push_*` integration tests each carry their own byte-identical copy of the same two helpers, `checkpoint()` and `field()`.

## Affected

```
tests/copilot_push_flaky.rs tests/copilot_push_partial.rs
tests/copilot_push_rotation.rs tests/copilot_push_held.rs
tests/copilot_push_interrupted.rs tests/copilot_push_invariants.rs
tests/copilot_push_loss.rs (+ copilot_push_quarantine.rs, split from flaky)
```

## Why it was not fixed in #228

The duplication was noticed while splitting `copilot_push_flaky.rs` to satisfy the LoC gate. Lifting the helpers into `tests/support/` touches eight files, which does not belong in a gate fix on an already-large branch. Following the existing convention was the smaller, more reviewable choice at the time.

## Scope

Move both helpers into `tests/support/` (a small `checkpoint.rs` module beside `copilot.rs`, exported from `support/mod.rs`) and delete the copies. Purely mechanical; no assertion should change.

Note `support/copilot.rs` is at 196 lines against the 200 ceiling, so the helpers need their own module rather than being appended there.

## AI Usage Declaration

AI-assisted. File list produced by grep, not recalled. A human owns intent, verification and consequences.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.