ADORSYS-GIS / ADORSYS-GIS/converse-frontends
[Ticket]: Widen the Storybook Pages path filter
- 主要语言
- TypeScript
- 星标
- 0
- 派生
- 0
- 平均合并
- 1 小时 49 分钟
- 30 天内合并 PR
- 253
描述
## Type
Bug
## Summary
We need to widen the Storybook Pages path filter because `storybook-pages.yml` is hardcoded to
`packages/ui/**`, so `packages/ui-web` — the design system the console actually uses — has never
once had its Storybook deployed.
Expected result:
> `storybook-pages.yml` triggers on changes to `packages/ui-web/**` as well, and `packages/ui-web`'s
> Storybook publishes.
## Intent
`packages/ui-web` is the live design system for `apps/console`; the console workstream cannot get
visual review/QA value from a Storybook that never deploys. This is a small, isolated fix that
unblocks that.
## Source of truth (links)
ADR 0009, Decision 1: https://github.com/ADORSYS-GIS/converse-frontends/blob/main/docs/adr/0009-nextjs-console-replacement.md
## Current Behavior
`storybook-pages.yml`'s path filter is hardcoded to `packages/ui/**`. Changes to `packages/ui-web`
never trigger the workflow, so `packages/ui-web`'s Storybook has never published.
## Expected Behavior
`storybook-pages.yml`'s path filter includes `packages/ui-web/**`. A change to `packages/ui-web`
triggers the workflow and its Storybook publishes.
## Acceptance Criteria
- [ ] Given a change to `packages/ui-web` after this ticket merges, when pushed, then
`storybook-pages.yml` runs and publishes its Storybook.
- [ ] Given `packages/ui` (soon to be deleted per Story 5.1), when this ticket lands, then the
filter change does not depend on that deletion having already happened.
- [ ] Error cases are handled safely: the widened filter does not accidentally trigger on unrelated
path changes.
- [ ] Existing behavior is not broken: any other package currently covered by the filter continues
to publish as before.
- [ ] Relevant tests are added or updated: not applicable beyond a workflow dry-run/verification
run.
- [ ] Verification evidence is provided (see below).
## Out of Scope
Removing `packages/ui/**` from the filter (handled naturally once Story 5.1 deletes the package;
not required by this ticket). Any content/story changes within `packages/ui-web` itself.
## Technical Context
`.github/workflows/storybook-pages.yml` — the path filter to widen.
## Risks
Low — this is a single-file, additive path-filter change. Minimal risk of regressing existing
Storybook publishing for other covered packages.
## Test Plan
- Push a trivial change under `packages/ui-web` and confirm `storybook-pages.yml` triggers and
completes.
- Confirm the published Storybook URL serves `packages/ui-web`'s stories.
## Verification evidence
To be filled in at delivery time: workflow run link, published Storybook URL.
## Human accountable owner
@stephane-segning
## AI Usage Declaration
- Ticket decomposition
## Human verification completed
- [ ] I understood the intent
- [ ] I checked the source of truth
- [ ] I reviewed all AI-generated text/code
- [ ] I verified the implementation manually
- [ ] I verified the tests
- [ ] I checked for hallucinated assumptions
- [ ] I documented remaining risks
- [ ] I am the accountable owner and accept responsibility for this ticket.
贡献指南
评估
这个 Issue 还没有评估数据。