99designs / 99designs/gqlgen

Inconsistent Parsing Error

Open
#2,112 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
10.8k
Forks
1.3k
Avg merge
2d 36m
Merged PRs (30d)
26

Description

### What happened?
When I have a string field in input and I pass in a wrong type, I am seeing different error code.
For example:
`{"input":{"filter":{"someString": true}}}`, I pass in a boolean for a string, and this would give me `GRAPHQL_VALIDATION_FAILED` error.

But if I do `{"input":{"filter":{"someString": 123}}}`, it would pass the validation and give me `json.Number is not a string`.

### What did you expect?
Both should give me `GRAPHQL_VALIDATION_FAILED`

### Minimal graphql.schema and models to reproduce

### versions
- `go run github.com/99designs/gqlgen version`?
v0.16.0
- `go version`?
go version go1.17.6 darwin/amd64

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.