99designs / 99designs/cmdstalk

Job priority not adhered to when consuming multiple tubes

Open
#18 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
76
Forks
14
PR merge metrics
No merged PRs in 30d

Description

When I execute `cmdstalk -cmd my-command -tubes pages,listing`, cmdstalk [starts two "reserve loops"](https://github.com/99designs/cmdstalk/blob/fbd704da919d283643e673bd02efcf0221224b92/broker/broker_dispatcher.go#L48). There are two problems with this:
* Suddenly the concurrency to execute jobs becomes _two_. Instead of one. This can strain downstream resources if you are not prepared.
* Due the above, jobs with different priorities are not taken into account.

beanstalkd supports having a single connection to consume multiple tubes. That's the proposed fix here.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.