99designs / 99designs/cmdstalk

Resource leak when tube is removed and -all is used

Open
#14 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
76
Forks
14
PR merge metrics
No merged PRs in 30d

Description

I was reading the source and thought I would report a tiny bug such that no one runs into it:

[`watchNewTubes()` method](https://github.com/99designs/cmdstalk/blob/fbd704da919d283643e673bd02efcf0221224b92/broker/broker_dispatcher.go#L82-L95) only starts new worker dispatchers, but never closes down preexisting ones if a tube is removed. If you have a lot of tubes being created and destroyed, you will run out of memory eventually.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.