9001 / 9001/copyparty

Strange --dav-auth behaviour

未关闭
#615 3 条评论 0 个 reaction 已指派 1 人 已被 @9001 认领 在 GitHub 查看
bug
主要语言
Python
星标
46.6k
派生
1.9k
平均合并
10 天 16 小时
30 天内合并 PR
5

描述

### Describe the bug
--dav-auth is required to actually accept password instead of authing as anonymous, but user still can be authorized to dav even without that option by IP

### To Reproduce
Add copyparty without --dav-auth flag as webdav in cx explorer 2.3.4. No matter the password user you will be authed as anonymous, unless your IP is mapped to specific user

### Expected behavior
It not ignores password without --dav-auth or also ignores IP

### Additional context
Keep in mind that some dav clients aren't allowing even trying to connect without password. Trying to login as not user mapped to client IP wasn't tested.
Even if --dav-auth meant to allow auth, not force, authorizing by IP bypasses it.

If you don't get how wrong it feels:
Known ip + right password: OK
--dav-auth from allowed ip: OK
--dav-auth from unknown ip: OK
unknown ip + right password: FAIL (uh???)
unknown ip + wrong password: FAIL (obviously)
--dav-auth with unknown password: refused

where OK is being authorised to desired profile and FAIL being authorised as anonymous

In my situation leaving house (and switching to mobile nerwork) was unauthing me even with right password until I enabled --dav-auth. Even if that's how it should've been that behaviour is unexpected

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。