3Hren / 3Hren/msgpack-rust

Option serializing is fundamentally broken

Open
#312 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
1.4k
Forks
162
PR merge metrics
No merged PRs in 30d

Description

It doesn't serialize the enumerator.
```rust
fn serialize_some(self, v: &T) -> Result<(), Self::Error> {
v.serialize(self)
}
```
It would probably make sense to change this to encode `None` as a 0-sized array and `Some` as a 1-sized array.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.