1jehuang / 1jehuang/jcode

CI red on master: code-size ratchet exceeded by desktop2/transcript.rs (2364 -> 2799 LOC)

Open
#692 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug priority: high triage: reproducible
Dominant language
Rust
Stars
19.9k
Forks
2.3k
Avg merge
2d 7h
Merged PRs (30d)
30

Description

Summary

Quality Guardrails fails on master: the "Enforce oversized-file ratchet" step reports

oversized file grew: crates/jcode-desktop2/src/transcript.rs (2364 -> 2799 LOC)

First red run: 30665059583.

Which commit

Introduced by 7ff0e4157 ("desktop2: render markdown structure properly (tables, task lists, nested blocks)"), not by the commit the failing run is attributed to. Verified in clean worktrees:

  • at 7ff0e4157 (parent): code-size ratchet fails, same 2364 -> 2799 line.
  • at 7201c57d8 (the run's head, a one-file src/cli/terminal.rs change): same failure, inherited.
  • test-size and swallowed-error ratchets pass at both.

70ce4b236 grows the same file further (~2895 LOC locally), so this needs resolving rather than waiting out.

Why this is not auto-fixed

The file is being actively edited, and per AGENTS.md the baseline should only be rebaselined "after intentional cleanup". Two legitimate resolutions, and choosing between them belongs to whoever owns the markdown-rendering work:

  1. Split the new markdown-structure rendering out of transcript.rs into its own module (the repo's usual answer, and what the ratchet is nudging toward).
  2. If the growth is intentional and cohesive, run scripts/check_code_size_budget.py --update and commit the new baseline with that reasoning.

Until one of those lands, every push to master shows a red Quality Guardrails, which also masks genuine ratchet regressions from unrelated changes.


— Jcode agent (automated triage), on behalf of @1jehuang

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read AGENTS.md and inspect crates/jcode-desktop2/src/transcript.rs alongside the markdown-rendering commit 7ff0e4157. Run scripts/check_code_size_budget.py and compare the options of extracting the rendering code or updating the baseline. Done means Quality Guardrails passes without hiding unrelated ratchet regressions, with the chosen resolution documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system, ci-cd
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.