1jehuang / 1jehuang/jcode

master CI is red (ratchet baselines) + Windows-only Python tooling/test bugs

Open
#547 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug priority: high triage: reproducible
Dominant language
Rust
Stars
19.9k
Forks
2.3k
Avg merge
2d 7h
Merged PRs (30d)
30

Description

Summary

Two classes of problem, both verified on a Windows host with no Rust toolchain (so this covers only the Python/CI surface; no .rs touched):

1. master CI is currently RED (highest priority)

On a clean checkout of origin/master (ccf6153e), three ratchet checkers fail because merged growth outran their baselines:

  • check_code_size_budget.py
  • check_test_size_budget.py
  • check_swallowed_error_budget.py

.github/workflows/ci.yml runs all three as hard gates, so the Quality-Guardrails job fails on every push/PR. The fix is a baseline --update, the same remedy as prior commits e376f74a / 92498403.

2. Windows-only Python tooling/test bugs (invisible in Linux CI)
  • analyze_runtime_memory_log.py reads logs with path.read_text() (no encoding), so on Windows (cp1252) it crashes with UnicodeDecodeError on any UTF-8 log containing multi-byte chars (emoji/curly quotes in session titles).
  • reload_recovery_audit.py reads durable recovery *.json and session transcripts with no encoding, inside except Exception: continue, so on Windows non-ASCII recovery records are silently dropped from the audit rather than crashing.
  • test_openrelay_discovery_test.py launches its fixture server by executing a .py path directly (shebang), which raises WinError 193 on Windows, making all 3 tests unrunnable.
  • check_powershell_syntax.ps1 only scanned scripts/, leaving .github/scripts/*.ps1 (run by Windows CI) unguarded.

Fix

A branch with 6 low-risk commits (all under scripts/, 0 .rs) fixes each of the above, each with a regression test where applicable. Every non-compile CI gate verified green via a one-command reproducer. PR incoming.

Environment

Windows, cp1252 locale, no cargo/rustc (so Rust-gated jobs were not run; unaffected since no Rust source changed).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with .github/workflows/ci.yml and reproduce the Quality-Guardrails failures from the three ratchet checkers: check_code_size_budget.py, check_test_size_budget.py, and check_swallowed_error_budget.py. Then inspect analyze_runtime_memory_log.py, reload_recovery_audit.py, test_openrelay_discovery_test.py, and check_powershell_syntax.ps1, including the .github/scripts/*.ps1 coverage. Done means the baseline gates and the Windows regression tests pass, with the reported encoding, fixture-launch, and PowerShell coverage issues addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, powershell, python
Domain
ci-cd, testing-qa, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.