123ishaTest / 123ishaTest/ludiek
Reconsider `amount` for input and output
Abierto
good first issue
help wanted
- Lenguaje dominante
- TypeScript
- Estrellas
- 12
- Forks
- 4
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
#83 introduced input and output. While very useful, the `amount` property can sometimes be awkward as it doesn't make sense for all resources (e.g. `AchievementOutput`)
Consider refactoring it to also implement a `getAmount()` which defaults to `input.amount` if it's available and if not errors. Basically ensure that one is implemented. Can also already be done at engine construction
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Evaluación
Este issue todavía no se ha evaluado.