CSS Code Review
Nobody has claimed this yet.
- Dominant language
- Nunjucks
- Stars
- 547
- Forks
- 726
- Avg merge
- 2h 23m
- Merged PRs (30d)
- 3
Description
@zachleat,
Picking up the conversation from #407 with @Ryuno-Ki about refactoring the CSS for performance and long-term maintenance. I have no idea if and/or how you might like to move forward with a project of this scale, but Pandora’s Box is now ajar if you’d like to finish opening it.
If you’re open to suggestions, I would recommend adopting an OOCSS pattern in the templates and CSS, at least for the inline critical assets. I think it would drastically shrink the number of style rules (right now ~232 inline and and other 100ish async). I follow a pattern like this on my site.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing issue #407 and the current inline and asynchronous CSS referenced here. Compare the templates and CSS with the linked OOCSS example, then define the scope before changing anything. Done would mean an agreed refactoring approach that reduces style-rule duplication while preserving the documentation site’s styling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100