0xPlaygrounds / 0xPlaygrounds/subgrounds

Incorrect Pagination leading to missing results

Open
#11 0 comments 0 reactions 0 assignees View on GitHub
bug need-validation
Dominant language
Python
Stars
73
Forks
12
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
Missing data due to Incorrect pagination.

**To Reproduce**
Steps to reproduce the behavior:
- Query any subgraph which has e.g. a `timestamp` and should return > 1800 entities.
- After the first pagination, instead of using `"skip: 1800"` and `"first: 900"`
- in my case it uses `"skip: 0", "first: 900"` and `"timestamp_gt: $lastOrderingValue0"`.
- If the timestamp of result with index 1800 is the same as 1801, this will skip 1801 and any other events which happen to have the same timestamp as index 1800.

**Expected behavior**
Results with same timestamp as the last returned timestamp from the previous result set of the pagination are present.

> Sorry I'm not experienced enough with the library to understand how it determines over which field to paginate - a briefer summary is that pagination shouldn't occur over fields which are not guaranteed to be unique.

*Originally from: [roama3](https://github.com/roama3)*

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.