0xMiden / 0xMiden/protocol

Simplify TransactionKernel package APIs

未關閉
#3,194 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
rust
主要語言
Rust
星號
132
分支
167
平均合併
1 天 23 小時
30 天內合併 PR
110

描述

#3146 added package debug execution, so `TransactionKernel` now exposes package, program, debug info, and entrypoint source node separately.

Motivating PR comment:

- https://github.com/0xMiden/protocol/pull/3146#discussion_r3516257274

The main path is [`crates/miden-protocol/src/transaction/kernel/mod.rs`](https://github.com/0xMiden/protocol/blob/2432a082e53c7e16b2885c8ee42e05489480358c/crates/miden-protocol/src/transaction/kernel/mod.rs#L73-L163). The package debug accessors are new in #3146, so this permalink points at the PR head.

Callers now combine these separate values in:

- [`crates/miden-tx/src/executor/mod.rs`](https://github.com/0xMiden/protocol/blob/2432a082e53c7e16b2885c8ee42e05489480358c/crates/miden-tx/src/executor/mod.rs#L202-L266)
- [`crates/miden-tx/src/executor/notes_checker.rs`](https://github.com/0xMiden/protocol/blob/2432a082e53c7e16b2885c8ee42e05489480358c/crates/miden-tx/src/executor/notes_checker.rs#L439-L449)

Please reshape `TransactionKernel` around package first access after the VM package execution API exists.

The kernel should expose the few values callers need, without making each caller know how to pair a program with package debug info and an entrypoint source node.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。