0xMiden / 0xMiden/miden-vm

Make ParsingError non-exhaustive in v0.33.0

Open
#3,816 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
772
Forks
352
Avg merge
1d 12h
Merged PRs (30d)
93

Description

`miden_assembly_syntax::parser::ParsingError` is a public, exhaustive enum. Mark it `#[non_exhaustive]` in v0.33.0. Downstream matches will then require a fallback arm, so later variants can be added without breaking client builds.

[PR #3812](https://github.com/0xMiden/miden-vm/pull/3812) records why this is needed. It restored the v0.32.0 enum layout after new variants broke the v0.32.1 patch release.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.