0xMiden / 0xMiden/miden-vm

Revisit code duplication between `Smt` and `LargeSmt`

Open
#3,494 0 comments 0 reactions 0 assignees View on GitHub
merkle
Dominant language
Rust
Stars
772
Forks
352
Avg merge
1d 12h
Merged PRs (30d)
93

Description

There is overlap between `Smt` and `LargeSmt`. For example, `LargeSmt::build_subtrees_from_sorted_entries(...)` mirrors logic in the concurrent `Smt`.

We should revisit both implementations and reduce code duplication where possible to simplify maintenance and keep behavior consistent.

From PR 0xMiden/crypto#438 discussions [here](https://github.com/0xMiden/crypto/pull/438#discussion_r2320879897), [here](https://github.com/0xMiden/crypto/pull/438#discussion_r2320859090) and [here](https://github.com/0xMiden/crypto/pull/438#discussion_r2320834570).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.