0xMiden / 0xMiden/miden-vm

Investigate: should `syscall` be allowed from context 0

Offen
#2,717 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Rust
Sterne
772
Forks
352
Ø Merge
1 T. 12 Std.
Gemergte PRs (30 T.)
93

Beschreibung

In #2296, we allowed the syscall operation to be called from context 0. As mentioned in that PR description,

>It is also worth noting that syscalls were also previously disallowed in a syscall context. In this PR we allow them, as there is no difference between
>
> - a syscall from context 0 at the start of the program (previously allowed), and
> - a syscall from context 0, where context 0 was entered due to a SYSCALL.

In other words, the old processor (`Process`) used to use the `in_syscall` register to check if `SYSCALL` should be allowed (and analogously, the constraint would check the `in_syscall` column to determine if the syscall is allowed). Hence, syscalls have always been allowed in context 0, specifically when context 0 was not entered from a syscall.

The solution in #2296 was to uniformly allow for syscalls in context 0, as there were no reason to disallow it. Though this should be revisited if we missed anything back then.

Related to the removal of the `in_syscall` column: https://github.com/0xMiden/miden-vm/issues/1681#issuecomment-3415807040

cc @bobbinth

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.