Implement`adv.push_smtset` and `adv.push_smtget`
- Ngôn ngữ chính
- Rust
- Star
- 772
- Fork
- 352
- Merge trung bình
- 1 ngày 12 giờ
- Pull request đã merge (30 ngày)
- 93
Mô tả
Prior to #1215, these instructions worked with the `TieredSmt`. They are currently not used in the `smt` implementation, but could be useful to improve performance.
_Originally posted by @bobbinth in https://github.com/0xPolygonMiden/miden-vm/pull/1215#discussion_r1468429893_
>I would keep them here but remove comments. The reason is that using these instructions we can optimize the implementation further. The way to do it is to pre-load advice info onto the advice stack here so that MASM code needs to do fewer `adv.push_mapvaln` operations (and associated stack manipulations). We can also use this to put binary flags onto the advice stack to flatten control flow a bit.
>
>My rough guess is that by using these techniques we could probably reduce cycle count of `smt::set` by 10% - 20%. The case of `smt::get` is not clear - savings there will probably be pretty small. But we can determine this and act accordingly in another PR.
>
>So, let's create an issue for this.
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.