0chain / 0chain/0chain

Block merge if code coverage on NEW code is < 70%

Offen
#424 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Code Quality devops post-mainnet
Vorherrschende Sprache
Go
Sterne
121
Forks
63
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

We currently have a code coverage reporter for our go code.
However there are a few tweaks we could make.

On all GO repos:
1. Code coverage is for all code, not a delta against develop. This means a PR could have zero coverage but overall levels could remain high giving false confidence.
2. Code coverage levels do not currently block a PR from merging. This should be automated and enforced

See https://github.com/0chain/blobber/issues/151

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Look at the existing code coverage reporter setup in the Go repositories. Examine the linked issue #151 in the blobber repo for context. The task involves modifying CI/CD to compute coverage delta against the develop branch and enforce a 70% threshold on new code to block merges. Start by understanding the current coverage tool (likely go test with cover) and the CI configuration (e.g., GitHub Actions).

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
go
Bereich
ci-cd, testing-qa
Issue-Typ
Feature
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
35/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.