07th-mod / 07th-mod/watanagashi

All-Cast Review suddenly mentions console arc

Offen
#102 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Keine Sprachdaten
Sterne
45
Forks
19
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

I noticed that in the All-Cast Review Session there is this odd line that assumes the player has played Taraimawashi:

![20200725135714_1](https://user-images.githubusercontent.com/59459967/88464238-1404ff00-ce87-11ea-9a89-785fba527794.jpg)

Since it would be extremely unlikely that a PC player had read that already - even in the console arc flowchart, it branches off from Tatarigoroshi - to me this feels like a line that shouldn't be updated when on lower voice matching levels. It's minor, but it was jarring for me when I read through it today, and for a minute I thought I'd somehow skipped something! It looks like the un-updated line is just " ...Both this time and last time.", which makes more sense.

I'm up for making this change myself, especially as I'd already be making a pull request for a different small change in this section. The problem is that I am unclear on if there's a policy for a specific voice matching level (GCensor value?) that should be used. Is that up to my discretion - in which case I'd probably set the current line to happen at 3, so it's higher than the default 2 - or are there clearer guidelines?

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Rechercherichtung

Find the All-Cast Review Session script file, likely in a scripts or text directory. Look for the line referencing Taraimawashi and the GCensor value controlling its display. Determine the appropriate voice matching level threshold (e.g., 3) to apply, then test by running the game or checking script conditions to ensure the line updates correctly.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Bereich
content
Issue-Typ
Bug
Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
40/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.