07th-mod / 07th-mod/umineko-question
Voiced and Unvoiced Delay Bugs
- Vorherrschende Sprache
- C#
- Sterne
- 98
- Forks
- 10
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
the scene immediately following this line has the !s0 problem (text doesn't appear until line is finished)
`She took it, ......and after hesitating, opened it...and read what was inside`
```
langjp^^!s0 そして、真に謝るのは自分の方であることを自覚し、/
langjp^^!d800…/
langjp^^!d500…/
langjp^^!d500…/
langjp^^!d500…/
langjp^^!d500謝罪した。/
langen^^!s0^Then, realizing that she was the one who should be apologizing, ^/
langen:delay 1600^...^/
langen:delay 1000^...^/
langen:delay 1000^...^/
langen:delay 1000^...^/
langen:delay 1000^she apologized.^/
```
On chiru, the bug only affected voice lines? but maybe that was just a coincidence and there was something else breaking the automatically displaying text lines.
Also, the delays haven't been adjusted? They seem too short most of the time.
Edit: somehow changing the 'delay [delaytime]' commands to '!d[delaytime]` makes it show up correctly (as per japanese mode):
```
langen^^!s0^Then, after letting two large tears...^/
langen!d1600^drip down the paper, ^@/
langen^...she flew out of the room, ^/
langen!d1600^hugged Maria from behind as she headed for the bathroom, ^@/
langen^......buried her face into her daughter's back...^/
langen!d3000^and cried.^/
langjp!sd\
langen!sd\
```
Also, why are all the delay values multiplied by 2 as compared to the japanese lines? Will have to check the git logs to see if someone just doubled all t he delays in the entire script.
----
I think the following steps are required:
- change all the `delay X` to `!d`. This fixes the strange 'delay before line is shown' bug. (Sometimes the `delay X` used to be `!w` which has slightly different behavior - `!w` is a forced wait which stops you from clicking through. But fixing that can be done later)
- divide the delay amount by 2. I think the 2x delay was added in this commit: 0625660 ("Fixing issue with delay lines part 2", 2016-07-18) . However, it was applied globally, even to lines which had no voices on them.
- for lines with voices only, scale the delay by the amount necessary + 100ms buffer. Also, test that the delay seems the correct amount.
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Rechercherichtung
Das Issue betrifft Timing-Fehler in den Dialogen eines Visual-Novel-Skripts. Sieh dir die bereitgestellten Skriptbeispiele an, die die Befehle 'langen:delay' und '!d' zeigen. Die Lösung beinhaltet Änderungen an der Befehlssyntax und Anpassungen der Verzögerungsmultiplikatoren. Beginne damit, den Skript-Parsing-Code des Spiels zu untersuchen, um zu verstehen, wie diese Befehle verarbeitet werden. Überprüfe den im Issue referenzierten Commit 0625660 für den historischen Kontext zur Verzögerungsskalierung. Teste Änderungen, indem du das Spiel ausführst und das Timing von Text und Sprachausgabe in der angegebenen Szene beobachtest.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- csharp
- Bereich
- game-dev
- Issue-Typ
- Bug
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 55/100