07th-mod / 07th-mod/python-patcher
Missing sharedassets0.assets file in language patch does not terminate install
- Dominant language
- JavaScript
- Stars
- 214
- Forks
- 12
- PR merge metrics
- No merged PRs in 30d
Description
Currently, if a matching `sharedassets0.assets` file is not found in the language patch, the installer will just hope for the best and use the default one.
It may be a better idea to stop the install with an error if this happens.
I think the way it works currently is that we extract the whole language patch archive directly, which automatically overwrites the sharedassets0.assets. But it may be better to leave the install as-is, without the language patch installed, if we know for sure it won't work.
----
Also see #192 if this is still to be treated as a warning, not an error
Contributor guide
No contributing guide indexed for this repository
Research direction
Look for the code that extracts the language patch archive and handles the sharedassets0.assets file. The installer likely has a function that checks for this file; modify it to raise an error or stop the installation if the file is missing. Check related issue #192 for context on warnings vs. errors. Test by simulating a language patch missing the sharedassets0.assets file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, python
- Domain
- cli, tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 65/100