07th-mod / 07th-mod/python-patcher
Launcher GUI doesn't work on Windows 7 installer (WontFix)
- Dominant language
- JavaScript
- Stars
- 214
- Forks
- 12
- PR merge metrics
- No merged PRs in 30d
Description
The UI based launcher doesn't work on windows 7. You can still install using the text-mode installer, however.
I'm just recording that the reason for this is:
- On Windows 7, the "job object" registration fails
- the "job object" was introduced to make sure that when you close the installer UI, the aria2c process is killed (so that it doesn't keep downloading in the background). This is only necessary when using the UI, as when using console/text mode installer, closing the console window will terminate aria2c automatically
- Therefore, even if the UI works, if the job object registration fails, we use the console/text mode installer, to make sure aria2c is killed if you close the installer (well, close the terminal). If we allowed the UI, we'd also be allowing the aria2c process to run in the background if you closed the UI window.
TODO:
- [ ] Note this in the wiki
- [ ] Add option to text mode installer to run from temp folder? This option is not given in the text mode installer.
Contributor guide
No contributing guide indexed for this repository
Research direction
The issue describes a Windows 7-specific failure in the GUI launcher's job object registration, which forces a fallback to the text-mode installer. Start by examining the installer code that handles process management and job objects on Windows. Look for the aria2c process spawning and the job object registration logic. Determine if a workaround exists for Windows 7 or if the fallback behavior is the intended solution. Testing on a Windows 7 environment or simulation would be necessary to verify any changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, python
- Domain
- cli, desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100