07th-mod / 07th-mod/higurashi-assembly

Slight black border on left and right hand sides of the screen

Ouverte
#64 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
C#
Étoiles
12
Forks
12
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Our mod has always had these 1-2 pixel borders on the left and right hand sides of the screen. Normally it's hard to see because it's black, but in certain cases, like a black image which is meant to cover a CG, it can result in the CG showing where the borders would be. Users usually report this happening on Onikakushi as it's the first time they see the graphical glitch.

The unmodded game does not have this issue.

@tellowkrinkle suggested it was a rounding issue, I'll look into that first when I (eventually) have a look at the issue:

> Probably a rounding issue somewhere
> I bet we (int) things, and with floating point error it might go over or under the target, causing - 1 pixel vs not - 1 pixel
> Try setting the aspect ratio to 0.65251 or something and see if that fixes it

modded:
![image](https://user-images.githubusercontent.com/1249449/113113730-5670ae00-9256-11eb-9f59-fe17b48bad65.png)

unmodded:
![image](https://user-images.githubusercontent.com/1249449/113113714-52dd2700-9256-11eb-8e30-ea71dfd20f4e.png)

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Piste de recherche

Look for aspect ratio or screen coordinate calculations in the codebase, likely in rendering or viewport setup. The issue mentions a rounding error when converting floats to ints; search for casts or integer truncations in graphics code. Test with the suggested aspect ratio 0.65251 to see if the black borders disappear, and verify by comparing modded vs unmodded rendering.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
csharp
Domaine
computer-graphics, game-dev
Type d'issue
Bug
Difficulté
3/5
Temps estimé
1-2 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
45/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.